Add a /test skill to run singular tests or per module tests#5111
Add a /test skill to run singular tests or per module tests#5111
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Map modules ending in -android to testDebugUnitTest so Android library modules like sentry-launchdarkly-android do not fall back to test. Add AskUserQuestion to allowed-tools so interactive mode can execute the decision prompts described in the skill under restricted tool settings. Co-Authored-By: Claude <[email protected]>
Sentry Build Distribution
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| With a test class filter: | ||
| ```bash | ||
| ./gradlew ':<module>:<task>' --tests="*<filter>*" --info | ||
| ``` |
There was a problem hiding this comment.
Gradle path template breaks for nested subproject modules
Medium Severity
The Gradle command template ':<module>:<task>' doesn't account for nested subprojects. Modules under sentry-opentelemetry/ are registered in settings.gradle.kts as sentry-opentelemetry:sentry-opentelemetry-core etc., requiring the Gradle path ':sentry-opentelemetry:sentry-opentelemetry-core:test'. Using just ':sentry-opentelemetry-core:test' would cause Gradle to fail with "project not found" for all six OpenTelemetry submodules.
Additional Locations (1)
|
|
||
| 1. Ensure the Python venv exists: | ||
| ```bash | ||
| test -d .venv || make setupPython |
There was a problem hiding this comment.
Venv existence check skips dependency installation
Low Severity
The command test -d .venv || make setupPython skips setupPython entirely when .venv already exists. The Makefile's setupPython target only gates venv creation on directory existence — it always runs pip install -r requirements.txt to ensure dependencies stay current. The Makefile's own systemTest target unconditionally depends on setupPython for this reason. This short-circuit means stale or missing Python dependencies won't be installed, causing confusing import failures when requirements.txt changes.
2 participants
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog